Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NOTEs after win-devel R CMD CHECK #84

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

jakubsob
Copy link
Collaborator

@jakubsob jakubsob commented May 17, 2024

Resolve NOTES after running win-devel check.

Changes

  • Fixed URLs
Before * using log directory 'd:/RCompile/CRANguest/R-devel/shiny.react.Rcheck' * using R Under development (unstable) (2024-05-16 r86559 ucrt) * using platform: x86_64-w64-mingw32 * R was compiled by gcc.exe (GCC) 13.2.0 GNU Fortran (GCC) 13.2.0 * running under: Windows Server 2022 x64 (build 20348) * using session charset: UTF-8 * checking for file 'shiny.react/DESCRIPTION' ... OK * this is package 'shiny.react' version '0.4.0' * package encoding: UTF-8 * checking CRAN incoming feasibility ... [11s] NOTE Maintainer: 'Jakub Sobolewski '

New maintainer:
Jakub Sobolewski jakub.sobolewski@appsilon.com
Old maintainer(s):
Kamil Żyła opensource+kamil@appsilon.com

  • checking package namespace information ... NOTE
    Found export directive that requires package 'methods':
    'exportMethods'
    Remove all such namespace directives (if obsolete) or ensure that the
    DESCRIPTION Depends or Imports field contains 'methods'.
  • checking package dependencies ... OK
  • checking if this is a source package ... OK
  • checking if there is a namespace ... OK
  • checking for hidden files and directories ... OK
  • checking for portable file names ... OK
  • checking serialization versions ... OK
  • checking whether package 'shiny.react' can be installed ... OK
  • checking installed package size ... OK
  • checking package directory ... OK
  • checking for future file timestamps ... OK
  • checking 'build' directory ... OK
  • checking DESCRIPTION meta-information ... OK
  • checking top-level files ... OK
  • checking for left-over files ... OK
  • checking index information ... OK
  • checking package subdirectories ... OK
  • checking code files for non-ASCII characters ... OK
  • checking R files for syntax errors ... OK
  • checking whether the package can be loaded ... OK
  • checking whether the package can be loaded with stated dependencies ... OK
  • checking whether the package can be unloaded cleanly ... OK
  • checking whether the namespace can be loaded with stated dependencies ... OK
  • checking whether the namespace can be unloaded cleanly ... OK
  • checking loading without being on the library search path ... OK
  • checking use of S3 registration ... OK
  • checking dependencies in R code ... OK
  • checking S3 generic/method consistency ... OK
  • checking replacement functions ... OK
  • checking foreign function calls ... OK
  • checking R code for possible problems ... OK
  • checking Rd files ... OK
  • checking Rd metadata ... OK
  • checking Rd line widths ... OK
  • checking Rd cross-references ... OK
  • checking for missing documentation entries ... OK
  • checking for code/documentation mismatches ... OK
  • checking Rd \usage sections ... OK
  • checking Rd contents ... OK
  • checking for unstated dependencies in examples ... OK
  • checking installed files from 'inst/doc' ... OK
  • checking files in 'vignettes' ... OK
  • checking examples ... OK
  • checking for unstated dependencies in 'tests' ... OK
  • checking tests ... OK
    Running 'testthat.R'
  • checking for unstated dependencies in vignettes ... OK
  • checking package vignettes ... OK
  • checking re-building of vignette outputs ... OK
  • checking PDF version of manual ... [21s] OK
  • checking HTML version of manual ... OK
  • DONE
    Status: 2 NOTEs
After * using log directory 'd:/RCompile/CRANguest/R-devel/shiny.react.Rcheck' * using R Under development (unstable) (2024-05-16 r86559 ucrt) * using platform: x86_64-w64-mingw32 * R was compiled by gcc.exe (GCC) 13.2.0 GNU Fortran (GCC) 13.2.0 * running under: Windows Server 2022 x64 (build 20348) * using session charset: UTF-8 * checking for file 'shiny.react/DESCRIPTION' ... OK * this is package 'shiny.react' version '0.4.0' * package encoding: UTF-8 * checking CRAN incoming feasibility ... [10s] NOTE Maintainer: 'Jakub Sobolewski '

New maintainer:
Jakub Sobolewski jakub.sobolewski@appsilon.com
Old maintainer(s):
Kamil Żyła opensource+kamil@appsilon.com

  • checking package namespace information ... OK
  • checking package dependencies ... OK
  • checking if this is a source package ... OK
  • checking if there is a namespace ... OK
  • checking for hidden files and directories ... OK
  • checking for portable file names ... OK
  • checking serialization versions ... OK
  • checking whether package 'shiny.react' can be installed ... OK
  • checking installed package size ... OK
  • checking package directory ... OK
  • checking for future file timestamps ... OK
  • checking 'build' directory ... OK
  • checking DESCRIPTION meta-information ... OK
  • checking top-level files ... OK
  • checking for left-over files ... OK
  • checking index information ... OK
  • checking package subdirectories ... OK
  • checking code files for non-ASCII characters ... OK
  • checking R files for syntax errors ... OK
  • checking whether the package can be loaded ... OK
  • checking whether the package can be loaded with stated dependencies ... OK
  • checking whether the package can be unloaded cleanly ... OK
  • checking whether the namespace can be loaded with stated dependencies ... OK
  • checking whether the namespace can be unloaded cleanly ... OK
  • checking loading without being on the library search path ... OK
  • checking use of S3 registration ... OK
  • checking dependencies in R code ... OK
  • checking S3 generic/method consistency ... OK
  • checking replacement functions ... OK
  • checking foreign function calls ... OK
  • checking R code for possible problems ... OK
  • checking Rd files ... OK
  • checking Rd metadata ... OK
  • checking Rd line widths ... OK
  • checking Rd cross-references ... OK
  • checking for missing documentation entries ... OK
  • checking for code/documentation mismatches ... OK
  • checking Rd \usage sections ... OK
  • checking Rd contents ... OK
  • checking for unstated dependencies in examples ... OK
  • checking installed files from 'inst/doc' ... OK
  • checking files in 'vignettes' ... OK
  • checking examples ... OK
  • checking for unstated dependencies in 'tests' ... OK
  • checking tests ... OK
    Running 'testthat.R'
  • checking for unstated dependencies in vignettes ... OK
  • checking package vignettes ... OK
  • checking re-building of vignette outputs ... OK
  • checking PDF version of manual ... [21s] OK
  • checking HTML version of manual ... OK
  • DONE
    Status: 1 NOTE

@jakubsob jakubsob force-pushed the pass-win-devel-check branch from 95be8ae to e46a561 Compare May 17, 2024 12:52
@jakubsob jakubsob changed the title chore: resolve NOTEs after win-devel R CMD CHECK Fix NOTEs after win-devel R CMD CHECK May 17, 2024
@jakubsob jakubsob marked this pull request as ready for review May 17, 2024 13:24
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubsob jakubsob merged commit e12eebc into main May 20, 2024
1 check passed
@jakubsob jakubsob deleted the pass-win-devel-check branch May 20, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants